Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag for the API #35756

Closed
MatShir opened this issue Mar 27, 2024 · 0 comments · Fixed by #35772 or PrestaShop/ps_apiresources#25 · May be fixed by PrestaShop/autoupgrade#686
Closed

Remove feature flag for the API #35756

MatShir opened this issue Mar 27, 2024 · 0 comments · Fixed by #35772 or PrestaShop/ps_apiresources#25 · May be fixed by PrestaShop/autoupgrade#686
Assignees
Labels
API Feature Type: New Feature Needs Tests UI Status: PR needs some UI Tests

Comments

@MatShir
Copy link
Contributor

MatShir commented Mar 27, 2024

Issue

The endpoint logic of API has been deported to a module and core foundation of the API can therefor be added to the software definitely. The API can still be disabled if needed

Specs

Remove the feature auth server in the feature and experimental page.
Keep the feature flag about the multistore but rename it "Admin API - Multistore"
Rename "Auth Server" page to "Admin API" above bellow Webservice Page,

Add new card on the bellow of the API client list.

The new card is named "Configuration" with the configuration icon and be composed with a toggle to enable and disable the API.
The toggle is named "Admin API", the input can be "Enabled" or "Disabled"
The help text is:
"Before enabling the Admin API, you must be sure to:

  1. Check that the ps_apiressource is installed and enabled.
  2. Check that URL rewriting is available on this server.
  3. Check that the six methods GET, POST, PUT, PATCH, DELETE and HEAD are supported by this server.
    The multistore is still on beta, to test it out go the "New & Experimental features" page*

Upgrade module need to be adapted accordingly.
The default value for new shops will be enabled

Acceptance test

When the Admin API is enabled
Then API can interrogate
Else the API won't be access and throw a denied access 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment