Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tab, roles and feature flags related to new Admin API #686

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jolelievre
Copy link
Contributor

Questions Answers
Description? Update tab, roles and feature flags related to new Admin API
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #{issue URL here}, Fixes #{another issue URL here}
Sponsor company ~
How to test? ~

@AureRita
Copy link

AureRita commented Apr 4, 2024

Hi @jolelievre

Thank you for your PR, I tested it and :

When I do an upgrade, I don't have the Api automatiquely checked like this PR add it :

#675

Except when I do it from a Multistore, the API button for Multistore is checked but not the Initial API, as you can see :

recording.176.webm

Moreover, When I do the Upgrade and I check the API Feature. I don't have the acces to it on BO as you can see on this screenshot

image

Tested from
8.0.5 -> 9.0.0
8.0.5 (Multistore) -> 9.0.0
8.0.5 -> 8.1.5 -> 9.0.0
8.0.5 -> 8.1.5 (Multistore) -> 9.0.0

When I do It from
8.1.5 (Multistore) -> 9.0.0
8.1.5 -> 9.0.0

I have :
image

and when I clic on Authorization server, I have :
image

Even if I enable "Admin API - Enable experimental endpoints"

Do you know how to correct this things ?

Waiting for feedback

@jolelievre
Copy link
Contributor Author

Thanks @AureRita

I'll look into it, besides I have conflicts to fix anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for review
4 participants