Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollback to the travis checks #124

Merged
merged 9 commits into from Aug 17, 2018

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Aug 7, 2018

Restorations have been reported as broken on 1.7.

We add the process on Travis to certify it will still work in the future, then we fix the potential issues.

  • Add on Travis
  • Fix potential issues

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 force-pushed the test-rollback branch 5 times, most recently from c111b90 to 2593cb2 Compare August 7, 2018 14:18
PierreRambaud
PierreRambaud previously approved these changes Aug 7, 2018
Copy link
Member

@eternoendless eternoendless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r2.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Quetzacoalt91)


cli-rollback.php, line 27 at r2 (raw file):

 *  International Registered Trademark & Property of PrestaShop SA
 */

How about adding a little description here?


cli-rollback.php, line 31 at r2 (raw file):

$container = autoupgrade_init_container(dirname(__FILE__));

if (php_sapi_name() !== 'cli') {

Maybe this should be done before anything else?


classes/TaskRunner/ChainedTasks.php, line 40 at r2 (raw file):

    protected $step;

    public function run()

Missing phpdoc (I'm guessing it returns a status code where 0 == success)


classes/TaskRunner/ChainedTasks.php, line 66 at r2 (raw file):

    public function setOptions(array $options)
    {
    }

This method should be abstract, be removed, or do something

@Quetzacoalt91
Copy link
Member Author

Done, thanks @eternoendless.

For the next reviews can you please use GitHub? The diffs shouldn't be too complex on this repository.

@Quetzacoalt91 Quetzacoalt91 merged commit d9da091 into PrestaShop:dev Aug 17, 2018
@Quetzacoalt91 Quetzacoalt91 deleted the test-rollback branch August 17, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants