New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollback to the travis checks #124

Merged
merged 9 commits into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 7, 2018

Restorations have been reported as broken on 1.7.

We add the process on Travis to certify it will still work in the future, then we fix the potential issues.

  • Add on Travis
  • Fix potential issues

This change is Reviewable

eternoendless and others added some commits Aug 2, 2018

Merge pull request #97 from PrestaShop/dev
Merge dev into master for v4.0.0 release

@Quetzacoalt91 Quetzacoalt91 added this to the 4.1.0 milestone Aug 7, 2018

@eternoendless

Reviewed 9 of 9 files at r2.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Quetzacoalt91)


cli-rollback.php, line 27 at r2 (raw file):

 *  International Registered Trademark & Property of PrestaShop SA
 */

How about adding a little description here?


cli-rollback.php, line 31 at r2 (raw file):

$container = autoupgrade_init_container(dirname(__FILE__));

if (php_sapi_name() !== 'cli') {

Maybe this should be done before anything else?


classes/TaskRunner/ChainedTasks.php, line 40 at r2 (raw file):

    protected $step;

    public function run()

Missing phpdoc (I'm guessing it returns a status code where 0 == success)


classes/TaskRunner/ChainedTasks.php, line 66 at r2 (raw file):

    public function setOptions(array $options)
    {
    }

This method should be abstract, be removed, or do something

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 8, 2018

Member

Done, thanks @eternoendless.

For the next reviews can you please use GitHub? The diffs shouldn't be too complex on this repository.

Member

Quetzacoalt91 commented Aug 8, 2018

Done, thanks @eternoendless.

For the next reviews can you please use GitHub? The diffs shouldn't be too complex on this repository.

@Quetzacoalt91 Quetzacoalt91 merged commit d9da091 into PrestaShop:dev Aug 17, 2018

1 of 2 checks passed

code-review/reviewable 5 files, 4 discussions left (eternoendless, Quetzacoalt91)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:test-rollback branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment