Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 410 http code to redirect_type column #456

Merged
merged 1 commit into from Feb 15, 2022

Conversation

jf-viguier
Copy link
Contributor

@jf-viguier jf-viguier commented Jan 26, 2022

Questions Answers
Description? Add 410 http code to redirect_type column
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#27413
How to test? See other PR in Core
Possible impacts? none

Copy link
Member

@PululuK PululuK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jf-viguier
Copy link
Contributor Author

@hibatallahAouadni For testing, you have to launch this sql manually from https://github.com/PrestaShop/autoupgrade/pull/456/files :

ALTER TABLE `ps_product` MODIFY COLUMN `redirect_type` ENUM(
    '404', '410', '301-product', '302-product', '301-category', '302-category'
) NOT NULL DEFAULT '404';
ALTER TABLE `ps_product_shop` MODIFY COLUMN `redirect_type` ENUM(
    '404', '410', '301-product', '302-product', '301-category', '302-category'
) NOT NULL DEFAULT '404';

I've replaced PREFIX_ by standard prefix ps_

@Progi1984 Progi1984 merged commit ee4c37e into PrestaShop:dev Feb 15, 2022
@Progi1984
Copy link
Contributor

I merge it as PrestaShop/PrestaShop#27467 is merged.

@Progi1984 Progi1984 added this to the 4.15.0 milestone Feb 15, 2022
@hibatallahAouadni
Copy link

Hello everyone,

The only issue I encountred with this PR is due to this issue PrestaShop/PrestaShop#26503
So, LGTM, QA ✔️

image

As you can see the new redirect type 410 is well added in the product & product_shop tables 🎉

Thanks!

@hibatallahAouadni hibatallahAouadni self-assigned this Feb 15, 2022
@matks matks mentioned this pull request Apr 25, 2022
atomiix pushed a commit to atomiix/autoupgrade that referenced this pull request Sep 16, 2022
Add 410 http code to redirect_type column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants