New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hooks displayAdminThemesListAfter and displayModuleConfigureExtraButtons for 8.0.0 #462
Conversation
sowbiba
commented
Feb 22, 2022
Questions | Answers |
---|---|
Description? | Add hooks displayAdminThemesListAfter and displayModuleConfigureExtraButtons for autoupgrade of 8.0.0 |
Type? | new feature |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | See PrestaShop/PrestaShop#27469 and PrestaShop/PrestaShop#27461 |
How to test? | - |
Possible impacts? | - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SQL is broken ^^
68f7afd
to
3951dac
Compare
oups. Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sowbiba,
I tested it and hooks that you add for autoupgrade isn't show,
as you can see on this video
Can't change hooks of Autoupgrade
Untitled_.Mar.15.2022.11_31.AM.mp4
Moreover, with the module Quality assurance, we only find "displayModuleConfigureExtraButtons" and not "displayAdminThemesListAfter" as you can see :
the display module is here :
0658ffc
0658ffc
to
f79c2d7
Compare
hi @sowbiba I don't see any label, it is waiting for QA ? =) |
We normally have to wait for the 2nd approval. But, as it's just a rebase, you can start your testing ;) |
Hi @sowbiba I do an autoupdate from 1.7.8.5 to 8.0.0 and we have some exceptions : On BO : instead of : Because of the exception on Design > Position, I can't check the hook on autoupgrade, I see that's a common issue between all these pages Thank you for persisting on this pr |
Hello @AureRita , you choosed a non working module to install (Gamiphy) If you want to test a working module with configure page, you can use |
Hello @sowbiba I tested you PR with an autoupgrade from 1.7.8.5 to 8.0.0, I deleted the module gamiphy (it break the design> position and other tab as you say it) but currently, the module autoupgrade didn't have other hook as you can see : Untitled_.Apr.26.2022.9_34.AM.mp4 |
I understand now. My hook is not an autoupgrade hook, it's a BO hook. In the list of hooks Design > Positions, just filter with the names (displayAdminThemesListAfter and displayModuleCOnfigureExtraButtons) to have them |
After installing a module which use them of course, like the example module I gave here PrestaShop/PrestaShop#27469 and here PrestaShop/PrestaShop#27461 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AureRita |
Add hooks displayAdminThemesListAfter and displayModuleConfigureExtraButtons for 8.0.0