Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change limit of filed value on ps_customized_data so that it can accepts more than 255 characters #556

Merged
merged 2 commits into from Feb 3, 2023
Merged

Change limit of filed value on ps_customized_data so that it can accepts more than 255 characters #556

merged 2 commits into from Feb 3, 2023

Conversation

lartist
Copy link

@lartist lartist commented Jan 30, 2023 •
edited

Questions Answers
Description? Change limit of filed value on ps_customized_data so that it can accepts more than 255 characters
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#27579
Sponsor company
How to test?
  1. Install a shop with version older than develop
  2. upload module autoupgrade with this PR merged
  3. Use autoupgrade to upgrade to develop
  4. Install classic theme with this Change limit of filed value on ps_customized_data so that it can accepts max 1024 characters classic-theme#100 merged (to be able to add more than 255 characters. You can instead remove the 255 characters constraint directly in the element inspector in your browser)
    5)You should be able to add more than 255 characters and the display of the value should not be truncated

mflasquin
mflasquin previously approved these changes Jan 30, 2023
View reviewed changes
jolelievre
jolelievre previously approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lartist

@lartist lartist dismissed stale reviews from jolelievre and mflasquin via 859867e January 31, 2023 14:25
@lartist lartist force-pushed the change-limit-on-customized-product-value branch from c56d083 to 859867e Compare January 31, 2023 14:25
jolelievre
jolelievre previously approved these changes Jan 31, 2023
View reviewed changes
@lartist lartist mentioned this pull request Jan 31, 2023
Merged
mflasquin
mflasquin previously approved these changes Jan 31, 2023
View reviewed changes
nicosomb
nicosomb previously approved these changes Jan 31, 2023
View reviewed changes
@paulnoelcholot paulnoelcholot self-assigned this Feb 2, 2023
@paulnoelcholot
Copy link

Hello @lartist,

I have tested your PR and I have found a bug :
image

@lartist
Copy link
Author

lartist commented Feb 3, 2023

Hello @lartist,

I have tested your PR and I have found a bug : image

Corrected. A too much comma in the request sorry.

@paulnoelcholot
Copy link

Hello @lartist

I have tested your PR and it's OK for me now 🎉

Thanks!

@paulnoelcholot paulnoelcholot removed their assignment Feb 3, 2023
@nicosomb nicosomb added this to the 4.15.1 milestone Feb 3, 2023
@nicosomb nicosomb merged commit c8464bc into PrestaShop:dev Feb 3, 2023
@nicosomb
Copy link
Contributor

nicosomb commented Feb 3, 2023

Thank you @lartist and @paulnoelcholot !

@Hlavtox Hlavtox modified the milestones: 4.15.1, 4.16.0 Mar 3, 2023
This was referenced Jul 29, 2023
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@mflasquin mflasquin mflasquin approved these changes

@jolelievre jolelievre jolelievre approved these changes

@paulnoelcholot paulnoelcholot paulnoelcholot approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland left review comments

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
4.16.0
7 participants
@lartist @paulnoelcholot @nicosomb @matthieu-rolland @mflasquin @jolelievre @Hlavtox