Add type in feature_flag table #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mflasquin
previously approved these changes
Jul 6, 2023
jolelievre
previously approved these changes
Jul 7, 2023
florine2623
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Hello @boherm ,
Tested the PR on 2 upgrades.
1.7.8.9 -> 8.0.4 ❌
1.7.8.9 -> 8.1.0 ❌
The upgrades didn't go well. The issue must come from my server.
@MhiriFaten could you check on your side the result ? 🤗
Thnaks!
|
Hi @florine2623! |
boherm
force-pushed
the
#32698-add-type-feature-flags
branch
from
11159ec
to
fdf8037
Compare
MhiriFaten
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Hello @boherm ,
I have checked your PR and LGTM 🚀
PS_1.7.8.9 ✔️
ROLLBACK ✔️
PS_8.0.4 ✔️
ROLLBACK ✔️
It is QA approved.
Thank you
M0rgan01
approved these changes
Jul 11, 2023
|
Thanks @boherm and @MhiriFaten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typecolumn infeature_flagtable needed for PrestaShop/PrestaShop#32923