Add force removing system for some files #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleon
approved these changes
Aug 1, 2023
matks
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
I think it's a good idea.
Even though the file is supposed to be deleted by the module, we know sometimes it fails. We know the deletion failure can happen if no XML file is provided, but it could also happen if a I/O fails at this moment.
So this workaround is OK 👍 . I think it's a good thing to force deletion of files we know are problematic if they stay around
|
I'm working on testing this. |
|
Related to PrestaShop/PrestaShop#33520 |
|
It's all good for me. Upgraded from 1.7.8.10 to 8.1.0. Everything went well. |
|
Thank you @boherm! |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we upgrade from < 1.7.8.X to 8.X.
This anomaly come when a
news.ymlfile stay in filesystem.(on 8.X versions, we have delete this file)
Maybe PrestaShop/PrestaShop#30761
2. Upgrade to 8.1.1 version.
3. The upgrade must be done with success.