Remove 1.6 related code

[Hlavtox]

Questions	Answers
Description?	Removes old 1.6 related code and upgrade scripts. Fixed return value when enableTheme failed - issue was hidden behind mixed return value.
Type?	refactor
BC breaks?	yes
Deprecations?	no
Fixed ticket?
Sponsor company
How to test?	Run upgrade from some old version, like 1.7.6, should go without issues.

[matks]

@Hlavtox You made the CI cry 😆

[darkWolf-PR]

What about to ... AT LEAST ... before removing 1.6 stuff, release a downloadable 4.14.3 version with this line:

autoupgrade/classes/UpgradeSelfCheck.php

Line 393 in 014ac06

return version_compare($this->getModuleVersion(), $upgrader->autoupgrade_last_version, '>=');

changed to:

return true;

So people, who actually needs to update from some older version can somehow do it?

Because writing this: "The minimum PrestaShop compatibility version has been bumped to 1.7. If you upgrade from a version older than 1.7, please use a previous version of this module." is just plain stupid as noone is able to actually use older version because of that check.

U just have to love PS for the need to hack stuff that should work... One line that I had to find and after which I can run my update from 1.6.1.9 to 1.6.1.24.

Sorry to mess this PR, I would write it into issues, but there are no issues or I don´t see em.

[matks]

What about to ... AT LEAST ... before removing 1.6 stuff, release a downloadable 4.14.3 version with this line:

autoupgrade/classes/UpgradeSelfCheck.php

Line 393 in 014ac06

return version_compare($this->getModuleVersion(), $upgrader->autoupgrade_last_version, '>=');

changed to:

return true;

So people, who actually needs to update from some older version can somehow do it?

Because writing this: "The minimum PrestaShop compatibility version has been bumped to 1.7. If you upgrade from a version older than 1.7, please use a previous version of this module." is just plain stupid as noone is able to actually use older version because of that check.

U just have to love PS for the need to hack stuff that should work... One line that I had to find and after which I can run my update from 1.6.1.9 to 1.6.1.24.

Sorry to mess this PR, I would write it into issues, but there are no issues or I don´t see em.

It's actually a good idea

[matks]

@darkWolf-PR See #626

[florine2623]

Hello @Hlavtox ,

Tested the following :

Upgrade went well from 1.7.6.4 to 1.7.8.0 ✅

Screen.Recording.2023-11-23.at.15.40.45.mov

[Hlavtox]

Thank you @florine2623! :-)