Fix for #33634 - Prevent overrides being wiped during upgrade to PS8 #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gennaris
commented
Aug 31, 2023
gennaris
commented
| Questions | Answers |
|---|---|
| Description? | Prevent existing overrides from being wiped during upgrade to PS8 |
| Type? | bug fix |
| BC breaks? | n/a |
| Deprecations? | n/a |
| Fixed ticket? | Fixes #33634 ( PrestaShop/PrestaShop#33634 ) |
| How to test? | Upgrade from PS 1.7.x to PS 8.x having some overrides - compare override folder before / after this PR |
gennaris
changed the title
kpodemski
previously approved these changes
Aug 31, 2023
|
thank you @gennaris :) |
kpodemski
reviewed
Aug 31, 2023
kpodemski
approved these changes
Aug 31, 2023
aniszr
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Hello @gennaris
I tested your PR and the described improvements are verified !
- Autoupgrade from PS 1.7.8.9 to PS 8.1.1 without PR
-> In the override folder there was at the bigenning 5 folders (classes,controllers,modules,index.php and .htaccess)
-> After the upgrade was done the override folder contain only 2 files (index.php and .htaccess)
- Autoupgrade from PS 1.7.8.9 to PS 8.1.1 with PR
->The override folder kept all his 5 files (classes,controllers,modules,index.php and .htaccess) after the upgrade was done
See attached screenrecord:
618._PrestaShop_autoupgrade.mp4
QA ✔️
Thank you!
|
thanks @gennaris 🎉 |
|
🥳 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.