Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop after upgrade with local module zip #623

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix infinite loop after upgrade with local module zip #623

merged 1 commit into from
Dec 19, 2023

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Sep 8, 2023 •
edited

Questions Answers
Description? Fix infinite loop after upgrade with local module zip
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#33866
Sponsor company PrestaShop SA
How to test?

aniszr
aniszr reviewed Sep 11, 2023
View reviewed changes
Copy link

@aniszr aniszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @matthieu-rolland

I tested the PR with two differents modules to make sure that the expected behavior is well executed:

  • Store upgrade from 8.0.5 to 8.1.1 ✔️
  • Module upgrade from local folder ✔️
  • Rollback process from 8.1.1 to 8.0.5 ❌

See attached screenrecord for error while Rollback process is executed:

Test.explo.pour.une.release.-.Google.Docs.mp4

See attached screenshot for error :

image

image

Thanks!

@AureRita AureRita self-assigned this Dec 19, 2023
AureRita
AureRita approved these changes Dec 19, 2023
View reviewed changes
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matthieu-rolland

Thank you for your PR, I tested it and it seems to works as you can see :

recording.9.webm

I tested with it the last MBO module to test it also.

Thank you

@nicosomb nicosomb merged commit d033afe into PrestaShop:dev Dec 19, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniszr aniszr aniszr left review comments

@nicosomb nicosomb nicosomb approved these changes

@boherm boherm boherm approved these changes

@AureRita AureRita AureRita approved these changes

Assignees

@AureRita AureRita

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
No milestone
5 participants
@matthieu-rolland @nicosomb @boherm @aniszr @AureRita