Fix upgrade inconsistencies

[Hlavtox]

Questions	Answers
Description?	Fixes some database incosistencies on upgraded installs found in PrestaShop/PrestaShop#33483. The differences do not necessarily mean something doesn't work, but removes the chance of biting us back with it. I fixed the things for both the original upgrade scripts AND 8.1.2, so we fix users that already upgraded.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#33975
Sponsor company
How to test?	Tests green + run the queries in 8.1.2.sql manually. Make sure to put SET SESSION sql_mode=''; to the beginning, or you will get an error 1067 because of bad default value in PREFIX_smarty_lazy_cache.

[boherm]

Looks good to me @Hlavtox, but can you resolve conflits? 😄

[aniszr]

Hello @Hlavtox

I tested your PR, and I didn't manage to verify all improvements you mentioned in description!

See detailed results obtained in Database after upgrade from 17.6.7 -> 8.1.2 :

• ps_product_attribute location is not removed after upgrade ❌
  ps_product_attribute quantity is not removed after upgrade ❌

  See attached screenshot:

• ps_smarty_lazy_cache cache_id is similar to 8.1.2 clean version ✔️

• ps_log : id_shop id_shop_group id_lang is similar to 8.1.2 clean version ✔️

• ps_product_attribute_lang : available_now , available_later is similar to 8.1.2 clean version ✔️

• ps_order_cart_rule : deleted is similar to 8.1.2 clean version ✔️

• ps_product_group_reduction_cache : reduction is similar to 8.1.2 clean version ✔️

• ps_stock_mvt : physical_quantity is similar to 8.1.2 clean version ✔️

• ps_order_payment : amount is similar to 8.1.2 clean version ✔️

Thank you !

[MatShir]

FYI it won't be part of 4.16.4. But, no worries, it will be part of the next patch with this coming fix PrestaShop/PrestaShop#33874 ;)

[aniszr]

Hello @Hlavtox

I retested your PR after your last improvement and it LGTM ✔️

The problem mentioned previousely in ps_product_attribute table is solved ✔️ :

• ps_product_attribute location is removed after upgrade ✔️

• ps_product_attribute quantity is removed after upgrade ✔️

See attached screenshot:

Thanks!