Added SQL commands related to doctrine and remove Doctrine usage #636

M0rgan01 · 2023-09-26T13:53:40Z

Questions	Answers
Description?	Added SQL commands related to doctrine, removing the execution of the command 'doctrine:schema:update'
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#33874, Fixes PrestaShop/PrestaShop#18113
Sponsor company	-
How to test?	Use https://github.com/PrestaShop/SeamlessUpgradeToolbox/tree/main/autoupgrade-scripts for test versions concerned. The SQL dump must be equivalent to a fresh install

Hlavtox · 2023-11-24T21:12:12Z

Guys what about this PR?

upgrade/sql/1.7.8.0.sql

Quetzacoalt91 · 2024-05-13T14:19:59Z

upgrade/sql/1.7.7.0.sql

@@ -312,7 +312,7 @@ ALTER TABLE `PREFIX_connections` CHANGE `http_referer` `http_referer` varchar(25
 ALTER TABLE `PREFIX_product_download` CHANGE `display_filename` `display_filename` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci NULL;

 /* Doctrine update happens too late to update the new enabled field, so we preset everything here */
-ALTER TABLE `PREFIX_tab` ADD enabled TINYINT(1) NOT NULL;
+ALTER TABLE `PREFIX_tab` ADD enabled TINYINT(1) NOT NULL, ADD route_name VARCHAR(256) DEFAULT NULL, CHANGE class_name class_name VARCHAR(64) NOT NULL;


We usually have one change per line, can you please split this one in 3?

Suggested change

ALTER TABLE `PREFIX_tab` ADD enabled TINYINT(1) NOT NULL, ADD route_name VARCHAR(256) DEFAULT NULL, CHANGE class_name class_name VARCHAR(64) NOT NULL;

ALTER TABLE `PREFIX_tab` ADD enabled TINYINT(1) NOT NULL;

ALTER TABLE `PREFIX_tab` ADD route_name VARCHAR(256) DEFAULT NULL;

ALTER TABLE `PREFIX_tab` CHANGE class_name class_name VARCHAR(64) NOT NULL;

Quetzacoalt91 · 2024-05-13T14:20:38Z

upgrade/sql/1.7.8.0.sql

+DROP INDEX id_shop ON `PREFIX_shop_url`;
+DROP INDEX full_shop_url ON `PREFIX_shop_url`;
+DROP INDEX full_shop_url_ssl ON `PREFIX_shop_url`;
+ALTER TABLE `PREFIX_shop_url` CHANGE id_shop_url id_shop_url INT AUTO_INCREMENT NOT NULL, CHANGE id_shop id_shop INT NOT NULL;


Suggested change

ALTER TABLE `PREFIX_shop_url` CHANGE id_shop_url id_shop_url INT AUTO_INCREMENT NOT NULL, CHANGE id_shop id_shop INT NOT NULL;

ALTER TABLE `PREFIX_shop_url` CHANGE id_shop_url id_shop_url INT AUTO_INCREMENT NOT NULL;

ALTER TABLE `PREFIX_shop_url` CHANGE id_shop id_shop INT NOT NULL;

Quetzacoalt91 · 2024-05-13T14:21:13Z

upgrade/sql/8.0.0.sql

+ALTER TABLE `PREFIX_feature_flag`
+    CHANGE  label_wording label_wording VARCHAR(512) DEFAULT '' NOT NULL,
+    CHANGE description_wording description_wording VARCHAR(512) DEFAULT '' NOT NULL;


Suggested change

ALTER TABLE `PREFIX_feature_flag`

CHANGE label_wording label_wording VARCHAR(512) DEFAULT '' NOT NULL,

CHANGE description_wording description_wording VARCHAR(512) DEFAULT '' NOT NULL;

ALTER TABLE `PREFIX_feature_flag` CHANGE label_wording label_wording VARCHAR(512) DEFAULT '' NOT NULL;

ALTER TABLE `PREFIX_feature_flag` CHANGE description_wording description_wording VARCHAR(512) DEFAULT '' NOT NULL;

Quetzacoalt91 · 2024-05-13T14:27:06Z

upgrade/sql/8.1.0.sql

+    scopes                    LONGTEXT     NOT NULL COMMENT '(DC2Type:array)',
+    INDEX                     IDX_6E064442D8BFF738 (id_authorized_application),
+    PRIMARY KEY (id_api_access)
+) DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = ENGINE_TYPE;


This may lead to the same result, but I saw the syntax was different for the other CREATE TABLE statements.

Suggested change

) DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = ENGINE_TYPE;

) ENGINE=ENGINE_TYPE DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

Quetzacoalt91 · 2024-05-13T14:27:32Z

upgrade/sql/8.1.0.sql

+    description               LONGTEXT     NOT NULL,
+    UNIQUE INDEX UNIQ_475B9BA55E237E06 (name),
+    PRIMARY KEY (id_authorized_application)
+) DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = ENGINE_TYPE;


This may lead to the same result, but I saw the syntax was different for the other CREATE TABLE statements.

Suggested change

) DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = ENGINE_TYPE;

) ENGINE=ENGINE_TYPE DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

M0rgan01 force-pushed the without_upgrade_modules branch 3 times, most recently from 6d29334 to 6732dd2 Compare September 26, 2023 15:15

matks changed the title ~~Added SQL commands related to doctrine~~ Added SQL commands related to doctrine and remove Doctrine usage Sep 27, 2023

Quetzacoalt91 reviewed Apr 17, 2024

View reviewed changes

upgrade/sql/1.7.8.0.sql Show resolved Hide resolved

M0rgan01 self-assigned this Apr 30, 2024

M0rgan01 force-pushed the without_upgrade_modules branch from 6732dd2 to 90190a5 Compare April 30, 2024 16:22

M0rgan01 added this to the 5.0.2 milestone Apr 30, 2024

M0rgan01 force-pushed the without_upgrade_modules branch from a251bdb to ac1f4e8 Compare May 2, 2024 10:08

M0rgan01 force-pushed the without_upgrade_modules branch from ac1f4e8 to 9199581 Compare May 13, 2024 14:00

M0rgan01 closed this May 13, 2024

M0rgan01 reopened this May 13, 2024

M0rgan01 added 8 commits May 13, 2024 16:04

Remove doctrine command execution

d33b4a3

Add 1.7.1.1 and 1.7.2.0 queries

a29ff44

Add 1.7.6. queries

3107619

Add 1.7.7 queries

8e80d3e

Add 1.7.8 queries

bd5d546

Add 8.0 queries

f671eb9

Add 8.1 queries

a1e64c4

Add v9 related queries

150a23f

M0rgan01 force-pushed the without_upgrade_modules branch from 9199581 to ac25f01 Compare May 13, 2024 14:05

M0rgan01 marked this pull request as ready for review May 13, 2024 14:06

Quetzacoalt91 reviewed May 13, 2024

View reviewed changes

Add 1.7.5 related changes

8fdf343

M0rgan01 force-pushed the without_upgrade_modules branch from ac25f01 to 8fdf343 Compare May 14, 2024 08:03

Quetzacoalt91 approved these changes May 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added SQL commands related to doctrine and remove Doctrine usage #636

Added SQL commands related to doctrine and remove Doctrine usage #636

M0rgan01 commented Sep 26, 2023 •

edited by Quetzacoalt91

Hlavtox commented Nov 24, 2023

Quetzacoalt91 May 13, 2024

Quetzacoalt91 May 13, 2024

Quetzacoalt91 May 13, 2024

Quetzacoalt91 May 13, 2024

Quetzacoalt91 May 13, 2024

	ALTER TABLE `PREFIX_shop_url` CHANGE id_shop_url id_shop_url INT AUTO_INCREMENT NOT NULL, CHANGE id_shop id_shop INT NOT NULL;
	ALTER TABLE `PREFIX_shop_url` CHANGE id_shop_url id_shop_url INT AUTO_INCREMENT NOT NULL;
	ALTER TABLE `PREFIX_shop_url` CHANGE id_shop id_shop INT NOT NULL;

	) DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = ENGINE_TYPE;
	) ENGINE=ENGINE_TYPE DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

Added SQL commands related to doctrine and remove Doctrine usage #636

Are you sure you want to change the base?

Added SQL commands related to doctrine and remove Doctrine usage #636

Conversation

M0rgan01 commented Sep 26, 2023 • edited by Quetzacoalt91

Hlavtox commented Nov 24, 2023

Quetzacoalt91 May 13, 2024

Choose a reason for hiding this comment

Quetzacoalt91 May 13, 2024

Choose a reason for hiding this comment

Quetzacoalt91 May 13, 2024

Choose a reason for hiding this comment

Quetzacoalt91 May 13, 2024

Choose a reason for hiding this comment

Quetzacoalt91 May 13, 2024

Choose a reason for hiding this comment

M0rgan01 commented Sep 26, 2023 •

edited by Quetzacoalt91