New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the APE field validation to match all formats #639
Conversation
alexandrebak42
commented
Oct 11, 2023
•
edited
edited
Questions | Answers |
---|---|
Description? | This PR is linked to PR 34242. It just update the PREFIX_customer.ape field from varchar(5) to varchar(6) to match all french APE code formats. I hope I haven't forgotten anything. |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes for PR 34242, Fixes for issue 34216 |
Sponsor company | coquille.fr |
How to test? | The ape field in PREFIX_customer table should be varchar(6) after upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @alexandrebak42! Thanks for your contribution.
As you target develop
branch (and so the 9.0.0 version of PrestaShop) in your PrestaShop/PrestaShop#34217, you have to edit the sql/9.0.0.sql
file instead of 8.1.3.sql
.
Oh ok sorry, this is my first PR on an open-source repository ! If I wanted the changes to take effect on 8.1.3 I should have done my PR on 8.1.X ? |
No problem! 😉
Yes, your PR must target the |
Nice, I created a new PR on 8.1.x here |
6d63a0a
I just resolved conflicts |
@alexandrebak42 Good job, works as it should. :-) |