Minimal_quantity should be 1 at least, not 0! #646
Conversation
ShaiMagal
commented
Nov 12, 2023
•
ShaiMagal
commented
| Questions | Answers |
|---|---|
| Description? | Tooltip say "The minimum quantity required to buy this product (set to 1 to disable this feature)". So minimal_quantity should be 1 at least, not 0! Related to PR: PrestaShop/PrestaShop#34537 |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | PrestaShop/PrestaShop#18850 |
| Sponsor company | https://www.openservis.cz/ |
| How to test? |
|
I will test these queries after the core PR is merged. |
|
@Hlavtox I am using this queries about 100 times per year, after every PS update to be sure. It's safe: |
|
@ShaiMagal Yeah, I meant for typos like missing comma, just to be sure. :-)) |
There was a problem hiding this comment.
@ShaiMagal you modify the 8.1.3 SQL file but this PR targets develop branch (= PrestaShop 9.0.0)
I think you should target branch 8.1.x ? so it would be delivered for PrestaShop 8.1.3
|
@matks I don't understand, my PR is for 8.1.x, not develop. |
There was a problem hiding this comment.
@matks I don't understand, my PR is for 8.1.x, not develop. PrestaShop/PrestaShop#34537
My bad I had too many browser tabs open
|
Hi @ShaiMagal, tested the query and everything works correctly, thank you!
|
