New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix normalizeVersion() levels on 8.x #661
Conversation
Seb33300
commented
Jan 6, 2024
Questions | Answers |
---|---|
Description? | Fix db upgrade from 8.x |
Type? | bug fix |
BC breaks? | yes |
Deprecations? | no |
Fixed ticket? | Fixes PrestaShop/PrestaShop#34987 |
Sponsor company | WEB AREA |
How to test? | Please check in the ticket |
e3f9c07
to
2eeb3ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
It seems like the QA couldn't reproduce the bug you're fixing... do you thing you can give them more context in the issue ? (your environment, anything specific that could help them reproduce ?)
I don't understand why QA cannot reproduce as I can reproduce by following the provided steps. But I think the code fixed is easy to understand. |
We have different staging environment of the same project, and I am not able to reproduce the issue on another environment. |
@matthieu-rolland I updated the ticket to add more information. It's a bit tricky. The issue happened because I tried to update to 8.1.2, and the autoupgrade module updated my database to 8.1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Seb33300
Thank you for your PR, I tested it and it seems to be fixed as we can see :
Untitled_.Jan.15.2024.3_50.PM.webm
But we still have Error as we can see :
@PrestaShop/tech-council do you think this error can be ignored ? because on the issue, at the start we don't have error
Except it, it'll be a QA ✔️
Thank you
The version number is properly detected. |
thank you @Seb33300 |