Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalizeVersion() levels on 8.x #661

Merged
merged 3 commits into from Jan 25, 2024

Conversation

Seb33300
Copy link
Contributor

@Seb33300 Seb33300 commented Jan 6, 2024

Questions Answers
Description? Fix db upgrade from 8.x
Type? bug fix
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#34987
Sponsor company WEB AREA
How to test? Please check in the ticket

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

It seems like the QA couldn't reproduce the bug you're fixing... do you thing you can give them more context in the issue ? (your environment, anything specific that could help them reproduce ?)

@Seb33300
Copy link
Contributor Author

I don't understand why QA cannot reproduce as I can reproduce by following the provided steps.

But I think the code fixed is easy to understand.
Currently it returns all version of PS with 4 levels (8.0.0.0, 8.1.0.0 ...)

@Seb33300
Copy link
Contributor Author

We have different staging environment of the same project, and I am not able to reproduce the issue on another environment.
But i still can reproduce it on the first one.
I will investigate and try to understand why...

@Seb33300
Copy link
Contributor Author

@matthieu-rolland I updated the ticket to add more information.

It's a bit tricky. The issue happened because I tried to update to 8.1.2, and the autoupgrade module updated my database to 8.1.3

@AureRita AureRita self-assigned this Jan 15, 2024
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Seb33300

Thank you for your PR, I tested it and it seems to be fixed as we can see :

Untitled_.Jan.15.2024.3_50.PM.webm

But we still have Error as we can see :
image

@PrestaShop/tech-council do you think this error can be ignored ? because on the issue, at the start we don't have error

Except it, it'll be a QA ✔️

Thank you

@Seb33300
Copy link
Contributor Author

The version number is properly detected.
And yes, the error is how it's supposed to show

@Seb33300
Copy link
Contributor Author

Seb33300 commented Jan 15, 2024

Previously you also had an error showing incorrect version number:

image

@kpodemski kpodemski added this to the 5.0.1 milestone Jan 25, 2024
@kpodemski kpodemski merged commit e81b188 into PrestaShop:dev Jan 25, 2024
25 checks passed
@kpodemski
Copy link
Contributor

thank you @Seb33300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants