Remove confusing and unused upgrade.php #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hlavtox
approved these changes
Apr 26, 2024
|
One question though - this file should be the one used for manual upgrade using browser, shouldn't we fix it instead? 🤔 |
I think we have to update documentation because we don't need to use |
ga-devfront
approved these changes
Apr 29, 2024
kpodemski
approved these changes
Apr 29, 2024
M0rgan01
approved these changes
Apr 30, 2024
|
I allow myself to merge this PR, as this does not require a check from the QA team. Thanks for your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade.phpshould have been deleted. It is a duplicate from cli-upgrade.php and does not run an upgrade as intended. For instance,PS_VERSION_DBwas only updated if the previous SQL requests have worked.