Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove addons links from the module #301

Merged
merged 5 commits into from Dec 16, 2021
Merged

Remove addons links from the module #301

merged 5 commits into from Dec 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2021 •
edited by ghost

Questions Answers
Description? Remove addons links from the module
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Needed ?
How to test? no test

@ghost ghost changed the title Remove addons link from the module Remove addons links from the module Oct 27, 2021
PierreRambaud
PierreRambaud reviewed Oct 27, 2021
View reviewed changes
blockreassurance.php Outdated Show resolved Hide resolved
@Touxten
Rmove adress key
c8e4ef6 
Update blockreassurance.php

Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>

PierreRambaud suggestion
@PierreRambaud PierreRambaud added the Improvement Type: Improvement label Oct 27, 2021
@Progi1984 Progi1984 added the waiting for QA Status: Waiting for QA feedback label Oct 29, 2021
@Progi1984 Progi1984 added this to the 5.1.0 milestone Oct 29, 2021
@florine2623 florine2623 self-assigned this Oct 29, 2021
@ghost
Copy link
Author

ghost commented Oct 29, 2021 •
edited by ghost

Hello @florine2623

@atomiix asked me for a correction we are waiting for addons answer can you delete Waiting for QA

Sincerely

@ghost
Copy link
Author

ghost commented Oct 29, 2021

I ping you when we have the answer

@florine2623
Copy link
Contributor

Thanks @okom3pom :)
Deleted the Waiting for QA label !

@florine2623 florine2623 removed the waiting for QA Status: Waiting for QA feedback label Oct 29, 2021
Progi1984
Progi1984 reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okom3pom Could you check the @atomiix feedback ?

Progi1984
Progi1984 reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last comment from @atomiix

@Progi1984 Progi1984 added the waiting for author Status: Waiting for Author Feedback label Nov 8, 2021
@Progi1984 Progi1984 added waiting for QA Status: Waiting for QA feedback and removed waiting for author Status: Waiting for Author Feedback labels Nov 8, 2021
@PierreRambaud PierreRambaud added Waiting for wording and removed waiting for QA Status: Waiting for QA feedback labels Nov 8, 2021
@PierreRambaud
Copy link
Contributor

It doesn't require QA, but @Julievrz can you have a check, please?

Julievrz
Julievrz reviewed Nov 9, 2021
View reviewed changes
blockreassurance.php Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Dec 7, 2021

Wording update @Julievrz

@PierreRambaud PierreRambaud added the waiting for QA Status: Waiting for QA feedback label Dec 7, 2021
atomiix
atomiix requested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@atomiix atomiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here still needs to be updated with @Julievrz's suggestion

@ghost
Copy link
Author

ghost commented Dec 7, 2021 •
edited by ghost

Oh nice catch thank @atomiix

Fixed

@Touxten
Update wording
be25d2d 
Forget wording

wording
@PierreRambaud PierreRambaud removed waiting for QA Status: Waiting for QA feedback waiting for dev labels Dec 8, 2021
@Julievrz
Copy link
Contributor

Hi, I can't remove the "waiting for wording" label for some reason. But the wording is ✔️, thanks!

@Progi1984 Progi1984 added waiting for QA Status: Waiting for QA feedback and removed Waiting for wording labels Dec 14, 2021
@Progi1984
Copy link
Contributor

@Julievrz OK. It's done.

@florine2623
Copy link
Contributor

Hello @okom3pom ,

Tested the module, works as intended.
Bug already reported here : #210

It is QA approved ✅
Thanks!

@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed waiting for QA Status: Waiting for QA feedback labels Dec 16, 2021
@Progi1984 Progi1984 merged commit 411db59 into PrestaShop:dev Dec 16, 2021
@Progi1984
Copy link
Contributor

Thanks @okom3pom & @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@florine2623 florine2623

Labels
Improvement Type: Improvement QA ✔️ Status: QA-Approved
Projects
None yet
Milestone
5.1.0
8 participants
@florine2623 @PierreRambaud @Julievrz @Progi1984 @matthieu-rolland @atomiix @sarahdib @Touxten