Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and description properties #50

Merged
merged 1 commit into from Jul 13, 2020
Merged

Conversation

cdefy
Copy link
Contributor

@cdefy cdefy commented Jul 9, 2020

Make title and description properties available for template separately. Keep text property for retro compatibility.

Questions Answers
Description? Made title and description property available for template. They are in different form fields in back-office but there is just "text" available for template so title and description can't be split for display. I just added the two properties to element, but maybe a better improvement will be to update template as well (replace text by title + description)
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Update template to use Smarty variables {$element.title} and {$element.description}

Make title and description properties available for template separately. Keep text property for retro compatibility.
@PierreRambaud PierreRambaud changed the base branch from master to dev July 13, 2020 09:51
@PierreRambaud
Copy link
Contributor

Not sure this one needs QA :)
We can merge after another approval!

@Progi1984 Progi1984 added waiting for QA Status: Waiting for QA feedback and removed waiting for QA Status: Waiting for QA feedback labels Jul 13, 2020
@Progi1984 Progi1984 merged commit 20678a4 into PrestaShop:dev Jul 13, 2020
@Progi1984
Copy link
Contributor

Thanks @PierreRambaud & @cdefy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants