Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added avif support to blockreassurance icon images #648

Merged
merged 3 commits into from Feb 29, 2024
Merged

Added avif support to blockreassurance icon images #648

merged 3 commits into from Feb 29, 2024

Conversation

buggyzap
Copy link
Contributor

Questions Answers
Description? I have added support to this new image format.
Type? improvement
BC breaks? no
Deprecations? no

Hi guys, I have simply added new .avif extension and image/avif mimetype to authorized.

boherm
boherm requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @buggyzap, thanks for your contribution. Just a little comment :)

controllers/admin/AdminBlockListingController.php Outdated Show resolved Hide resolved
@ps-jarvis ps-jarvis added the waiting for author Status: Waiting for Author Feedback label Feb 14, 2024
@buggyzap buggyzap requested a review from boherm February 14, 2024 11:01
@ps-jarvis ps-jarvis added the waiting for QA Status: Waiting for QA feedback label Feb 14, 2024
@florine2623 florine2623 self-assigned this Feb 23, 2024
florine2623
florine2623 reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @buggyzap ,

Thanks for the PR !
Tested on 8.1.x and develop.
LGTM ✅

Could you add the extension on the help block as well please ?
Screenshot 2024-02-23 at 09 12 45

@florine2623 florine2623 removed their assignment Feb 23, 2024
@buggyzap
Copy link
Contributor Author

Hello @buggyzap ,

Thanks for the PR ! Tested on 8.1.x and develop. LGTM ✅

Could you add the extension on the help block as well please ? Screenshot 2024-02-23 at 09 12 45

Ty I have added 1 more commit

@florine2623 florine2623 self-assigned this Feb 28, 2024
@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed waiting for author Status: Waiting for Author Feedback waiting for QA Status: Waiting for QA feedback labels Feb 28, 2024
florine2623
florine2623 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @buggyzap ! LGTM ✅

@ps-jarvis ps-jarvis added the waiting for QA Status: Waiting for QA feedback label Feb 28, 2024
@florine2623 florine2623 removed the waiting for QA Status: Waiting for QA feedback label Feb 28, 2024
@leemyongpakva leemyongpakva added this to the 6.0.0 milestone Feb 29, 2024
@leemyongpakva leemyongpakva merged commit 740d5fa into PrestaShop:dev Feb 29, 2024
@leemyongpakva
Copy link
Contributor

Thanks @buggyzap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florine2623 florine2623 florine2623 approved these changes

@boherm boherm boherm approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️ Status: QA-Approved
Projects
PR Dashboard
Archived in project
Milestone
6.0.0
5 participants
@buggyzap @leemyongpakva @florine2623 @boherm @ps-jarvis