Fix wrong class naming in Share.vue #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Oct 21, 2021
ghost
commented
| Questions | Answers |
|---|---|
| Description? | The CSS put into the Share.vue must target only the share modal and not the create modal. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #26349 |
| How to test? | See #26349 |
| Possible impacts? | Please indicate what parts of the software we need to check to make sure everything is alright. |
|
CI is broken, I need to fix it before the QA, gonna be done today or tomorrow! |
ghost
changed the title
NeOMakinG
force-pushed
the
fix-wrong-class-name-share-vue
branch
from
854ea65
to
8d72427
Compare
Progi1984
approved these changes
Oct 22, 2021
PierreRambaud
approved these changes
Oct 22, 2021
|
Hello @a-pare Thanks for your PR!
Thanks! |
|
Thanks @a-pare & @hibatallahAouadni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.