FO / Blockwishlist - bad display when wishlist name is too long in ta…

[akrambak]

FO / Blockwishlist - bad display when wishlist name is too long in tablet/mobile screens #29213

Questions	Answers
Description?	FO / Blockwishlist - bad display when wishlist name is too long in tablet/mobile screens #29213
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #29213
Sponsor company	Bakhouche Akram
How to test?	Front.

[0x346e3730]

Hello @akrambak, thank you for your contribution. Your PR only changes a builded version of the javascript, however you should need to change the source file, now the builded one.

[akrambak]

Hello @akrambak, thank you for your contribution. Your PR only changes a builded version of the javascript, however you should need to change the source file, now the builded one.

Hello, can you help me to find the path of the source file to change, a litle help, i will find it myself.

[mflasquin]

Hello @akrambak, thank you for your contribution. Your PR only changes a builded version of the javascript, however you should need to change the source file, now the builded one.

Hello, can you help me to find the path of the source file to change, a litle help, i will find it myself.

Hi @akrambak, you can see the wishlistcontainer is build with webpack, it contains files describes in .webpack/common.js :

wishlistcontainer: [ './_dev/front/js/container/WishlistContainer', './_dev/front/js/components/Create', './_dev/front/js/components/Delete', './_dev/front/js/components/Toast', './_dev/front/js/components/Share', './_dev/front/js/components/Rename', ],

So you have to update one of these file to fix the issue 😄
It it clear ?

[akrambak]

@mflasquin It's clear thks
I pushed a new commit 9b6a769
Is it okay ?

@0x346e3730

[kpodemski]

@akrambak almost! seems that you compiled assets in the dev mode, only by running the watch, is that true? you should run a build, so that assets get minified during compilation :)

[akrambak]

@akrambak almost! seems that you compiled assets in the dev mode, only by running the watch, is that true? you should run a build, so that assets get minified during compilation :)

For the first commit i edited the bundle compiled directly.
In the second commit i changed the source file.
I didn't compiled.

[akrambak]

@kpodemski i miss a ";"
Now it compile correctly, new commit cc2d57f

My Bad

all good

[florine2623]

Hello @akrambak ,

Thanks for your PR.

I have installed your PR, I have an exception :

I removed the rebase with

git rebase --abort
git merge --abort
git reset --hard

When I try to configure the module I have another exception :

Could you check ?
Thanks!

[akrambak]

@florine2623 i try a new commit
Build successful
I didn't touch to the blockreassurance, so your error seems to be not linked to my commit.

[akrambak]

@kpodemski can you rerun the tests please ?

[kpodemski]

thanks @akrambak I re-run the tests, I think everything's ok with your PR

let's wait for QA to re-test it :)

[florine2623]

Thanks @akrambak ! No more exception displayed !

I have retested, but I still encounter the original issue.

Your PR is well installed. I have rebuild the assets. Cleared cache from PS and from my browser. Am I missing something ?

cd _dev
rm -rf node_modules
npm i --verbose
npm run build

Screen.Recording.2023-03-31.at.13.57.24.mov

[akrambak]

@kpodemski Plz relanche the again. 3ab1489
@florine2623 the ";" was the last problem.
This time it will be Ok

[akrambak]

@kpodemski a new commit with "LF"
41bd361

[kpodemski]

thanks @akrambak

[florine2623]

Thanks @akrambak ,

It is looking good :)

Checked on multiple screens sizes (desktop, tablet and mobile), it always looks as expected !
The buttons still work as usual.

It is QA ✅ !

[kpodemski]

thank you @akrambak ! well done 👏🏻