New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm ci instead of npm install #225
Conversation
M0rgan01
commented
Jun 1, 2023
Questions | Answers |
---|---|
Description? | Use npm ci instead of npm install |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | - |
Sponsor company | - |
How to test? | - |
Hello @M0rgan01 what will happen to this PR 😉 ? |
@matks PHPStan (Latest) tests do not pass. Not related to PR changes. I have to see why. Before this there was a problem on the Build & Release draft stage. |
Now it's good ? 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Action passed https://github.com/PrestaShop/blockwishlist/actions/runs/6747287451/job/18343084897?pr=225
Running npm ci
will run npm install
AND verify the CI?
The main differences between using npm install and npm ci are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @M0rgan01