Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm ci instead of npm install #225

Merged
merged 1 commit into from Nov 3, 2023

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Jun 1, 2023

Questions Answers
Description? Use npm ci instead of npm install
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? -

@M0rgan01 M0rgan01 marked this pull request as draft June 1, 2023 13:49
@matks
Copy link
Contributor

matks commented Nov 3, 2023

Hello @M0rgan01 what will happen to this PR 😉 ?

@M0rgan01 M0rgan01 marked this pull request as ready for review November 3, 2023 15:38
@M0rgan01 M0rgan01 closed this Nov 3, 2023
@M0rgan01 M0rgan01 reopened this Nov 3, 2023
@M0rgan01
Copy link
Contributor Author

M0rgan01 commented Nov 3, 2023

@matks PHPStan (Latest) tests do not pass. Not related to PR changes. I have to see why. Before this there was a problem on the Build & Release draft stage.

@M0rgan01
Copy link
Contributor Author

M0rgan01 commented Nov 3, 2023

Now it's good ? 👍

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Action passed https://github.com/PrestaShop/blockwishlist/actions/runs/6747287451/job/18343084897?pr=225

Running npm ci will run npm install AND verify the CI?

@M0rgan01
Copy link
Contributor Author

M0rgan01 commented Nov 3, 2023

@matks

The main differences between using npm install and npm ci are:

  • The project must have an existing package-lock.json or npm-shrinkwrap.json.
  • If dependencies in the package lock do not match those in package.json, npm ci will exit with an error, instead of updating the package lock.
  • npm ci can only install entire projects at a time: individual dependencies cannot be added with this command.
  • If a node_modules is already present, it will be automatically removed before npm ci begins its install.
  • It will never write to package.json or any of the package-locks: installs are essentially frozen.

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @M0rgan01

@matks matks merged commit 1a3e582 into PrestaShop:dev Nov 3, 2023
13 of 16 checks passed
@matks matks added this to the 3.0.2 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
7 participants