Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove harmful inline styles #252

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Mar 3, 2024

Questions Answers
Description? Modals' inline styles caused them to be always active on the page, just invisible. They were blocking access to elements behind them on Hummingbird theme. Classic theme has different configuration of the footer where wishlist modals are hooked so the issue is hidden much better there and doesn't occur. These inline styles are just useless there. All required modals styles are already in .css file.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/hummingbird#594 PrestaShop/PrestaShop#35276
Sponsor company -
How to test? 1. Install Hummingbird theme on develop branch
2. Check if modals still block the center of the page.

obraz

blockwishlistbug.mp4

.wishlist-modal {
display: none;
opacity: 0;
pointer-events: none;
z-index: 0;
&.show {
display: block;
opacity: 1;
pointer-events: all;
z-index: 1051;

@SharakPL SharakPL requested a review from a team March 3, 2024 14:44
@SharakPL SharakPL added this to the 3.0.2 milestone Mar 4, 2024
@AureRita AureRita self-assigned this Mar 5, 2024
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SharakPL

Thank you for your PR, I tested it and it seems to works as you can see :

recording.128.webm

Tested on 8.1.x and develop

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita removed their assignment Mar 5, 2024
@SharakPL SharakPL merged commit d2653e7 into PrestaShop:dev Mar 5, 2024
12 checks passed
@SharakPL
Copy link
Contributor Author

SharakPL commented Mar 5, 2024

Thanks @AureRita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants