Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the number of items in stock before the 'Add to cart' button and before to the stock label #51

Closed

Conversation

AlexTechDev
Copy link
Contributor

Questions Answers
Description? This Pull Request creates the improvement requested in the issue PrestaShop/hummingbird#512
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/hummingbird#512
How to test? Steps Below :)

With this improvement we move number of stock before Add to Cart button.
If the user does not display or does not indicate this label we show the number of stock first and before the label "In Stock", for example: 300 in stock as @Julievrz propose in the issue.
If the user show the Stock Label we show the number of stock with the user label.

When user doesn't display stock label
image

When user display stock label
image

Important: We keep the stock number in the product details.

@NeOMakinG
Copy link

@AlexTechDev Thanks for the contrib!

why do we keep the stock in product details?

@AlexTechDev
Copy link
Contributor Author

Hi @NeOMakinG
It's a good point, It's better to keep it in both place? Or we can delete it from product details?

I have follow the issue and create the improvement but I think that the better is to show in stock label with the number of items if the user indicate the label, if the user doesn't indicate the label is because he wan't to show anything before the button so we can keep only in product details
What do you think?

@NeOMakinG
Copy link

The issue doesn't precise it but I guess we should remove it from product details, it's useless if we see it before, should be fine!

@Hlavtox
Copy link
Contributor

Hlavtox commented Sep 21, 2022

I think we should show both information and put more thinking into it. Putting a number before availability is not a good solution I think. 🤔

  • If my availability label is empty, it will show just 300?
  • If my availability label is blablabla, it will show 300 blablabla?
  • If my availability label is in stock with lowercase letter, it will show 300 in stock on product page, but in stock only with lowercase letter in product list.

@kpodemski kpodemski closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants