Use PHP built-in stripslashes for PS 8.0.0+ #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosomb
requested changes
Dec 18, 2023
| @@ -567,12 +567,13 @@ public function sendMessage() | |||
| && empty($mailAlreadySend) | |||
| && ($sendConfirmationEmail || $sendNotificationEmail) | |||
| ) { | |||
| $message = version_compare(_PS_VERSION_, '8.0.0', '>=') ? stripslashes($message) : Tools::stripslashes($message); | |||
There was a problem hiding this comment.
As this PR targets develop branch, I think that you can use built-in stripslashes() and remove the check on PrestaShop version.
There was a problem hiding this comment.
I think dev branch in this repo is somehow different from develop branch in Core repo :)
develop branch in Core repo means PS 9 for now, but dev branch in this repo supports PS 1.7.2+
There was a problem hiding this comment.
Oh my bad, I thought I was on prestashop repo.
nicosomb
approved these changes
Dec 18, 2023
florine2623
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Hello @leemyongpakvn ,
Tested with 8.1.x and 9.0.x.
Tested with logged in customer and guest. Tested with attachment or not. Tested with order reference or not.
LGTM ✅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools::stripslashes()is deprecated since version 8.0.0. Use PHP's stripslashes instead.