New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix best products image #16

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
3 participants
@gnujeremie
Contributor

gnujeremie commented Nov 13, 2017

Images displayed where using product id as part of their names, instead of image id.

@gnujeremie

This comment has been minimized.

Show comment
Hide comment
@gnujeremie

gnujeremie Nov 16, 2017

Contributor

Anybody ?

Contributor

gnujeremie commented Nov 16, 2017

Anybody ?

@gnujeremie

This comment has been minimized.

Show comment
Hide comment
@gnujeremie

gnujeremie Apr 26, 2018

Contributor

Come on seriously...

Contributor

gnujeremie commented Apr 26, 2018

Come on seriously...

@eternoendless

Sorry for the delay!

@gnujeremie

This comment has been minimized.

Show comment
Hide comment
@gnujeremie

gnujeremie Jul 12, 2018

Contributor

No problem, as long as it's merged ^^ (if there are no bug :D)

Contributor

gnujeremie commented Jul 12, 2018

No problem, as long as it's merged ^^ (if there are no bug :D)

@marionf marionf self-assigned this Jul 12, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Jul 12, 2018

Hello @gnujeremie
I see the same image for all products

capture d ecran_49

marionf commented Jul 12, 2018

Hello @gnujeremie
I see the same image for all products

capture d ecran_49

@marionf marionf removed their assignment Jul 12, 2018

@marionf marionf removed the Waiting for QA label Jul 12, 2018

@gnujeremie

This comment has been minimized.

Show comment
Hide comment
@gnujeremie

gnujeremie Jul 13, 2018

Contributor

I'll have to test it again then with the last prestashop version. When I made this change last november, it fixed the issue for me.

Contributor

gnujeremie commented Jul 13, 2018

I'll have to test it again then with the last prestashop version. When I made this change last november, it fixed the issue for me.

@gnujeremie

This comment has been minimized.

Show comment
Hide comment
@gnujeremie

gnujeremie Aug 6, 2018

Contributor

Ok I fixed my stupide typo. Sorry for that. It should be ok now.

Contributor

gnujeremie commented Aug 6, 2018

Ok I fixed my stupide typo. Sorry for that. It should be ok now.

@marionf marionf self-assigned this Aug 6, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Aug 6, 2018

Thank you @gnujeremie it works 👍

marionf commented Aug 6, 2018

Thank you @gnujeremie it works 👍

@marionf marionf added QA approved and removed Waiting for QA labels Aug 6, 2018

@marionf marionf removed their assignment Aug 6, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Aug 14, 2018

Thank you @gnujeremie

@eternoendless eternoendless merged commit ff42f4f into PrestaShop:dev Aug 14, 2018

@eternoendless eternoendless added this to the 2.0.4 milestone Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment