Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix best products image #16

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Fix best products image #16

merged 1 commit into from
Aug 14, 2018

Conversation

gnujeremie
Copy link
Contributor

Images displayed where using product id as part of their names, instead of image id.

@gnujeremie
Copy link
Contributor Author

Anybody ?

@gnujeremie
Copy link
Contributor Author

Come on seriously...

Copy link
Member

@eternoendless eternoendless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@gnujeremie
Copy link
Contributor Author

No problem, as long as it's merged ^^ (if there are no bug :D)

@marionf marionf self-assigned this Jul 12, 2018
@marionf
Copy link

marionf commented Jul 12, 2018

Hello @gnujeremie
I see the same image for all products

capture d ecran_49

@marionf marionf removed their assignment Jul 12, 2018
@gnujeremie
Copy link
Contributor Author

I'll have to test it again then with the last prestashop version. When I made this change last november, it fixed the issue for me.

@gnujeremie
Copy link
Contributor Author

Ok I fixed my stupide typo. Sorry for that. It should be ok now.

@marionf marionf self-assigned this Aug 6, 2018
@marionf
Copy link

marionf commented Aug 6, 2018

Thank you @gnujeremie it works 👍

@marionf marionf removed their assignment Aug 6, 2018
@eternoendless
Copy link
Member

Thank you @gnujeremie

@eternoendless eternoendless merged commit ff42f4f into PrestaShop:dev Aug 14, 2018
@eternoendless eternoendless added this to the 2.0.4 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants