Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad display in the Dashboard page #34

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Fix bad display in the Dashboard page #34

merged 2 commits into from
Oct 26, 2021

Conversation

khouloudbelguith
Copy link

@khouloudbelguith khouloudbelguith commented Oct 13, 2021

Questions Answers
Description? Bad display in the Dashboard of the module dashproducts
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#26231
How to test? Go to Dahsbord page, and check that Last %number of% orders is well displayed

Before
image
After
image

@marwachelly marwachelly self-assigned this Oct 19, 2021
@marwachelly
Copy link

marwachelly commented Oct 20, 2021

Hello @khouloudbelguith,
I tested the PR, it is ok but just when I resize the screen to 185px x 977px I noticed the following problem :
Test with PR:
image

Without PR
image

Could you please check.
Thanks,

@khouloudbelguith
Copy link
Author

Hi @marwachelly,

Thanks for your feedback.
I think it is a core issue not related to this module.
Ping @NeOMakinG what do you think?

Thanks!

@NeOMakinG
Copy link

Yep, UIKit problem.

But 187px isn't a viable screen width, is it working on 320px at least? If so, it's not an issue to me

@marwachelly
Copy link

Yep, UIKit problem.

But 187px isn't a viable screen width, is it working on 320px at least? If so, it's not an issue to me

Hello @NeOMakinG ,
For 320px the problem exist only when the title is long.
With PR:
image

without PR:
image
Thanks,

@khouloudbelguith
Copy link
Author

khouloudbelguith commented Oct 22, 2021

Hi @NeOMakinG, @marwachelly,

I created a new PR: PrestaShop/PrestaShop#26372 to fix the issue.
image

Thanks!

@NeOMakinG
Copy link

@khouloudbelguith is this PR QA validated then? :)

@marwachelly
Copy link

Hello,
PR is tested on the branch develop and with release 1.7.8.0. The issue is fixed.
image
Thanks,

@atomiix atomiix merged commit 36eed75 into dev Oct 26, 2021
@atomiix
Copy link
Contributor

atomiix commented Oct 26, 2021

Thanks @khouloudbelguith & @marwachelly

@atomiix atomiix deleted the fix-display branch October 26, 2021 13:26
@atomiix atomiix restored the fix-display branch October 26, 2021 13:26
@Progi1984 Progi1984 added this to the 2.1.2 milestone Nov 4, 2021
@Progi1984 Progi1984 added the bug label Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants