Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback on a previous version of constant #55

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fallback on a previous version of constant #55

merged 1 commit into from
Nov 23, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 23, 2023

Questions Answers
Description? PS_PROD_IMG_DIR is deprecated since 1.7.8.1 in favor of PS_PRODUCT_IMG_DIR. If we want to remove it, we must stop using it. If we want to keep the minimal version, let's use this condition.
Type? refacto
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

@Hlavtox Hlavtox added this to the 2.1.4 milestone Nov 23, 2023
@Hlavtox Hlavtox mentioned this pull request Nov 23, 2023
Merged
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 23, 2023

Doesn't need full QA - tested manually

Snímek obrazovky 2023-11-23 161935

@Hlavtox Hlavtox merged commit 17c26aa into PrestaShop:dev Nov 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
2.1.4
2 participants
@Hlavtox @nicosomb