Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard recent orders : display "Deleted customer" #57

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Dashboard recent orders : display "Deleted customer" #57

merged 1 commit into from
Jan 4, 2024

Conversation

HiCharly
Copy link
Contributor

@HiCharly HiCharly commented Dec 23, 2023 •
edited
Loading

Questions Answers
Description? On the recent orders tab of dashboard, display "Deleted customer" instead of empty field.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#30453.
How to test? 1. Create an order with a customer
2. Go to BO > check the table Products and Sales - Recent orders > The order is displayed in the Recent Orders
3. Delete this customer
4. Go to BO > Products and Sales - Recent orders > The customer field is not empty, but filled with "Deleted customer"

image

This is my first open source PR, feel free to advise me :)

@AureRita AureRita self-assigned this Dec 29, 2023
AureRita
AureRita approved these changes Dec 29, 2023
View reviewed changes
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HiCharly

Thank you for your PR, I tested it and it seems to works as you can see :

recording.31.webm

Because the PR seems to works as expected, It's QA ✔️

Great first PR, thank you for all details put on it.

Thank you

@nicosomb nicosomb added this to the 2.1.5 milestone Jan 4, 2024
@nicosomb nicosomb merged commit e40c7ef into PrestaShop:dev Jan 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@AureRita AureRita AureRita approved these changes

Assignees

@AureRita AureRita

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
2.1.5
5 participants
@HiCharly @matthieu-rolland @AureRita @nicosomb @ps-jarvis