Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Coveralls & Added support versions #15

Merged
merged 5 commits into from Mar 5, 2021
Merged

Migrate to Coveralls & Added support versions #15

merged 5 commits into from Mar 5, 2021

Conversation

Progi1984
Copy link
Contributor

Questions Answers
Description? Added support versions
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A
Possible impacts? N/A

@Progi1984 Progi1984 force-pushed the addSupportVersions branch 7 times, most recently from 72e873b to 2e60ba5 Compare February 26, 2021 13:20
@Progi1984 Progi1984 force-pushed the addSupportVersions branch 7 times, most recently from 4af7780 to 87d1bcf Compare February 26, 2021 14:28
@Progi1984 Progi1984 force-pushed the addSupportVersions branch 5 times, most recently from 3d18966 to 31a10bb Compare February 26, 2021 14:47
@Progi1984 Progi1984 changed the title Added support versions Migrate to Coveralls & Added support versions Feb 26, 2021
@PierreRambaud PierreRambaud merged commit 4abb285 into PrestaShop:develop Mar 5, 2021
@PierreRambaud
Copy link
Contributor

Thank you! Tests were failing because Coveralls token is not shared between forks and the main repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland left review comments

@atomiix atomiix atomiix approved these changes

@PierreRambaud PierreRambaud Awaiting requested review from PierreRambaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Progi1984 @PierreRambaud @matthieu-rolland @atomiix