Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of mjml #2

Merged
merged 2 commits into from
Oct 24, 2016
Merged

Upgrade version of mjml #2

merged 2 commits into from
Oct 24, 2016

Conversation

akiletour
Copy link
Contributor

Due to a bug with the 1.0.1 version gulp-mjml (cf. mjmlio/gulp-mjml#11) we need to upgrade to version 2

@Scritik
Copy link
Contributor

Scritik commented Oct 23, 2016

Thank you for the PR :)

What about removing the version to make sure we always have the latest version? This kind of dependency should be always up to date, no?

@ngarnier
Copy link

Hey guys, I'd suggest keeping the ^ to make sure you're up to date on the major version indeed. Not a fan of latest in case of a breaking change though.

@Scritik
Copy link
Contributor

Scritik commented Oct 24, 2016

@ngarnier: Yeah, you're right.

@akiletour: Can you fix your PR? So I can merge it and release a fix along this.

@Scritik Scritik merged commit 76f2cc4 into PrestaShopCorp:master Oct 24, 2016
@akiletour akiletour deleted the patch-1 branch October 25, 2016 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants