feat: add PR security testing without cache #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boubkerbribri
commented
Jan 11, 2024
•
boubkerbribri
commented
| Questions | Answers |
|---|---|
| Description? | feat: add PR security testing without cache using composite |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| Sponsor company | PrestaShopCorp |
| How to test? | Tested on a private repository |
boubkerbribri
commented
Jan 11, 2024
Comment on lines
+5
to
+10
| GH_REPOSITORY: | ||
| description: Pull request private repository | ||
| required: true | ||
| GH_TOKEN: | ||
| description: Github token to access the repository | ||
| required: true |
There was a problem hiding this comment.
Inputs added to set a repository and a personnel token to access it
Comment on lines
+183
to
+191
| - uses: actions/checkout@v3 | ||
| name: Checkout PrestaShop PR security private repository | ||
| with: | ||
| fetch-depth: 0 | ||
| repository: ${{ inputs.GH_REPOSITORY }} | ||
| token: ${{ inputs.GH_TOKEN }} |
There was a problem hiding this comment.
Where the new inputs are used
boubkerbribri
force-pushed
the
feat/pr-security
branch
from
cc67392
to
d6b76ff
Compare
boubkerbribri
force-pushed
the
feat/pr-security
branch
from
d6b76ff
to
c42be34
Compare
boubkerbribri
requested review from
Progi1984,
matthieu-rolland,
matks,
jolelievre and
nesrineabdmouleh
Progi1984
approved these changes
Jan 11, 2024
nesrineabdmouleh
approved these changes
Jan 11, 2024
jolelievre
approved these changes
Jan 11, 2024
matthieu-rolland
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.