Check if the hook is present before adding it

[Hlavtox]

Questions	Answers
Description?	Checks if the sitemap hook is not present in the system, otherwise the adding would fail. The hook can be there from other modules, fixtures or my a failed uninstall. Also I removed the removal of the hook during uninstall - because you would lost all modules hooked into there, and they would not get rehooked.
Type?	refacto
BC breaks?	no
Deprecations?	no
Fixed ticket?
How to test?	See below

➡️ Make sure to replace PREFIX_ in the queries with ps_ or whatever your prefix is.

How to test - scenario A

1. Uninstall this module.
2. Run following query in PHPMYADMIN. The hook may fail if you already have the hook there, but it's not a problem.

INSERT IGNORE INTO `PREFIX_hook` (`id_hook`, `name`, `title`, `description`, `position`) VALUES 
(NULL, 'gSitemapAppendUrls', 'GSitemap Append URLs', 'This hook allows a module to add URLs to a generated sitemap', '1');

3. Verify the hook is there by running:

SELECT * FROM `PREFIX_hook` WHERE name = 'gSitemapAppendUrls';

4. Install this module. It will work. It may not work without this PR.

How to test - scenario B

1. Uninstall this module.
2. Verify the hook stayed in the database by running. It was deleted before. With this PR, it stays.

SELECT * FROM `PREFIX_hook` WHERE name = 'gSitemapAppendUrls';

[florine2623]

Hell @Hlavtox ,

Tested both scenarios on 1.7.8.8, 8.0.2, 8.1.x and develop with gsitemap v4.2.0 and v4.2.1.

The module is well installed after a simple uninstall and/or uninstall with option delete module folder on PS 1.7.8.8 and 8.0.2. ✅

On PS 8.1.x and develop, it is NOK ❌

Am I missing something ?
Thanks 🤗

[Hlavtox]

@florine2623 Hi, can you retest it? It must have been some core issue, because I just tried it on 8.1.x and it works perfectly.

[Hlavtox]

@PrestaShop/qa-functional Hi again, can you retest?

[aniszr]

Hello @Hlavtox

I tested your PR with both scenarios on 8.1.x & Develop :

- 8.1.x :
The module is well installed after a simple uninstall and/or uninstall with option delete module folder ✔️

The hook stayed in the database ✔️

- Develop:
The module is well installed after a simple uninstall and/or uninstall with option delete module folder ✔️

The hook stayed in the database ✔️

QA ✔️

Thanks!