Remove function "GSITEMAP_CHECK_IMAGE_FILE" - too problematic

[ShaiMagal]

Questions	Answers
Description?	Function GSITEMAP_CHECK_IMAGE_FILE in this module is crazy thing, and "every second" customer enable it without knowing impact, for example on performance (there is EVERY image "opened" via get_headers). If eshop have for example 100 000 images, every single images is analyzes, so, in most of cases error 500. But maybe worse is problem, they enable this, and in bigger eshops or slow webhosting it doesn't run to end, so sitemap is outdated years (I saw this about 5 times already). We should remove this. It's useless function.
Type?	refacto
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #PrestaShop/PrestaShop#34572 + #PrestaShop/PrestaShop#32625 + #PrestaShop/PrestaShop#18508
How to test?	Regenerate sitemap, check it went OK

[Hlavtox]

You also need to change the version in config.xml, but otherwise it's OK for me. ;-)

[ShaiMagal]

@Hlavtox Ahhh, config.xml edit done :)

[matthieu-rolland]

Looks like csfixer is blocking the PR

To fix this you can run this command from the root of your project and then commit and push the modifications:

php vendor/bin/php-cs-fixer fix

[Hlavtox]

Code style fix is needed, please avoid autoformatting in the IDE, because it's using a different style apparently.

Also, it creates extra code changes and making the PR harder to review. 👍

[ShaiMagal]

@Hlavtox I rewrite changes manually from scratch.

@matthieu-rolland I don't have project for it (small changes).
Is there any other option how to fix it manully? I don't know, what to fix to be honest :) I see it's test "PHP tests / PHP-CS-Fixer (pull_request)" - but I don't know, what to change.

[Hlavtox]

Bad upgrade file name and method name. ;-)

[ShaiMagal]

@Hlavtox fixed. Tests green now.

[Hlavtox]

Nice, now, we just need to squash those commits so there is only 1. ;-)

[Hlavtox]

Verified the behavior, everything works correctly, including the upgrade. :-)

Minor issues found when testing this - fixed here - PrestaShop/PrestaShop#34731.