Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tab link #170

Merged
merged 1 commit into from Nov 23, 2023
Merged

Remove tab link #170

merged 1 commit into from Nov 23, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 23, 2023

Questions Answers
Description? Removes the usage of pre 1.6 link style, using tab as a parameter.
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test?

@Hlavtox Hlavtox added this to the 4.3.1 milestone Nov 23, 2023
@Hlavtox Hlavtox changed the title Update gsitemap.php Remove tab link Nov 23, 2023
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 23, 2023

Does not need QA, this style of link is obsolete at least since 1.5.0.1 - see https://github.com/PrestaShop/PrestaShop/blob/1.5.0.1/admin-dev/index.php.

@Hlavtox Hlavtox merged commit ff57a4e into PrestaShop:dev Nov 23, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaiMagal ShaiMagal ShaiMagal approved these changes

Assignees
No one assigned
Labels
waiting for QA
Projects
PR Dashboard
Archived in project
Milestone
4.3.1
3 participants
@Hlavtox @ShaiMagal @ps-jarvis