Merge pull request #432 from nicosomb/improve-a11y-ps-emailsubscription

PrestaShop · Feb 17, 2023 · cc02c6d · cc02c6d
2 parents 1c280c9 + 1d3fe49
commit cc02c6d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/modules/ps_emailsubscription/views/templates/hook/ps_emailsubscription-column.tpl b/modules/ps_emailsubscription/views/templates/hook/ps_emailsubscription-column.tpl
@@ -5,7 +5,7 @@
 
 <div class="block_newsletter" id="blockEmailSubscription_{$hookName}">
   <form action="{$urls.current_url}#blockEmailSubscription_{$hookName}" method="post">
-    <p id="block-newsletter-label">{l s='Get our latest news and special sales' d='Shop.Theme.Global'}</p>
+    <p id="block-newsletter-label-{$hookName}">{l s='Get our latest news and special sales' d='Shop.Theme.Global'}</p>
     <div class="mb-1">
       <input
         class="btn btn-primary float-end"
@@ -19,7 +19,8 @@
           type="email"
           value="{$value}"
           placeholder="{l s='Your email address' d='Shop.Forms.Labels'}"
-          aria-labelledby="block-newsletter-label"
+          aria-labelledby="block-newsletter-label-{$hookName}"
+          required
         >
       </div>
       <input type="hidden" name="blockHookName" value="{$hookName}" />

diff --git a/modules/ps_emailsubscription/views/templates/hook/ps_emailsubscription.tpl b/modules/ps_emailsubscription/views/templates/hook/ps_emailsubscription.tpl
@@ -9,7 +9,7 @@
   <div class="container px-1">
     <div class="{$componentName}__content row">
       <div class="{$componentName}__content__left col-md-5">
-        <p class="{$componentName}__label">{l s='Get our latest news and special sales' d='Shop.Theme.Global'}</p>
+        <p id="block-newsletter-label-{$hookName}" class="{$componentName}__label">{l s='Get our latest news and special sales' d='Shop.Theme.Global'}</p>
       </div>
 
       <div class="{$componentName}__content__right col-md-7">
@@ -21,7 +21,7 @@
               class="form-control"
               value="{$value}"
               placeholder="{l s='Your email address' d='Shop.Forms.Labels'}"
-              aria-labelledby="block-newsletter-label"
+              aria-labelledby="block-newsletter-label-{$hookName}"
               required
            >