Stylise psgdpr page #312
Merged
Stylise psgdpr page #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NeOMakinG
commented
Jun 1, 2022
NeOMakinG
commented
| Questions | Answers |
|---|---|
| Description? | Some style tweaks to be in accordance with mockups |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | closes #24 closes #30. |
| How to test? | Look at the gdpr page from your account |
added 2 commits
June 1, 2022 15:31
Hlavtox
reviewed
Jun 1, 2022
| <p>{l s='You have the right to modify all the personal information found in the "My Account" page. For any other request you might have regarding the rectification and/or erasure of your personal data, please contact us through our' mod='psgdpr'} <a href="{$psgdpr_contactUrl|escape:'htmlall':'UTF-8'}">{l s='contact page' mod='psgdpr'}</a>. {l s='We will review your request and reply as soon as possible.' mod='psgdpr'}</p> | ||
|
|
||
| {literal} | ||
| <script type="text/javascript"> |
There was a problem hiding this comment.
@NeOMakinG This should be changed in the core bro
There was a problem hiding this comment.
It would cause some regressions, that was a choice
There was a problem hiding this comment.
But well I guess this module isn't that used by others modules/themes, we could!
Co-authored-by: Matthieu Rolland <matthieu.rolland@prestashop.com>
|
@Hlavtox I'm afraid if we change the core, it will be considered as a BC for past themes, should we merge this PR at least for hummingbird first? |
|
@Hlavtox As the only blocker here is related to a question "Should we change it in the core?", let's merge this one and clear that template when it's done on core side, the theme can't wait for a core update on this anyway, we can be flexible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.