Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme preview in Readme #386

Merged
merged 1 commit into from Nov 9, 2022
Merged

Add theme preview in Readme #386

merged 1 commit into from Nov 9, 2022

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented Nov 4, 2022 •
edited

Questions Answers
Description? Add theme preview in Readme
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? See preview here https://github.com/PululuK/hummingbird/tree/add-theme-preivew-img
Possible impacts? N/A

@NeOMakinG
Copy link
Contributor

@Hlavtox wdyt? Feel free to merge if you agree with it

matks
matks approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me too, waiting for @Hlavtox opinion

@Hlavtox Hlavtox merged commit d2912d7 into PrestaShop:develop Nov 9, 2022
@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 9, 2022

Good for me 👍 Thank you @PululuK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PululuK @NeOMakinG @Hlavtox @matks