Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates: double quotes => single quote (for Smarty strings) #601

Merged
merged 2 commits into from Feb 29, 2024

Conversation

yannicka
Copy link
Contributor

Questions Answers
Description? Chunk of #593. Strings in Smarty templates all (or almost all) use single quotes instead of double quotes.
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Sponsor company N/A
How to test? Install the theme and browse the website.

kpodemski
kpodemski previously approved these changes Feb 23, 2024
Hlavtox
Hlavtox previously approved these changes Feb 23, 2024
@kpodemski
Copy link
Contributor

@yannicka after the merge of one of your PRs there are some conflicts there :( probably it will be a bit of a pain since your previous PR changed spaces 😓

@yannicka yannicka dismissed stale reviews from Hlavtox and kpodemski via 14b39b2 February 26, 2024 18:57
@yannicka
Copy link
Contributor Author

Should be good ;)

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yannicka ,

I tested with develop branch of PS and PHP 8.1.

I have an internal server error when installing the hummingbird theme PR.

Screenshot 2024-02-28 at 09 40 54

With classic theme, it works as expected.

Could you check ? :)
Thanks!

@florine2623 florine2623 removed their assignment Feb 28, 2024
@kpodemski
Copy link
Contributor

@florine2623, could you check what the logs say? because this is just a generic error message

@yannicka
Copy link
Contributor Author

For my part, I can install the theme with this modification, and the theme works.

If you activate debug mode, it will display more information.

@florine2623 florine2623 self-assigned this Feb 29, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yannicka ,

Retested the theme on develop. I do not have any errors. Probably a problem with my server 😅

Tested :

  • creation of a product in BO and checked product page in FO
  • checked categories page
  • log into customer page
  • checked customer account pages
  • processed to checkout
  • checked content pages

LGTM ✅

@Hlavtox Hlavtox merged commit 9446868 into PrestaShop:develop Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants