Remove useless todo's

PrestaShop · Aug 3, 2023 · fec256c · fec256c
1 parent 7f12eab
commit fec256c
Show file tree

Hide file tree

Showing 11 changed files with 5 additions and 16 deletions.
diff --git a/config/services.php b/config/services.php
@@ -34,7 +34,7 @@
             '../src/Kernel.php',
         ]);
 
-    // Todo: Config about messenger.message_handler not tested
+    //Note: The config about messenger.message_handler is not tested, be careful when you want to modify it
     $services->load('App\\PullRequest\\Application\\CommandHandler\\', '../src/PullRequest/Application/CommandHandler/')
         ->tag('messenger.message_handler');
 

diff --git a/src/PullRequest/Domain/Aggregate/PullRequest/PullRequest.php b/src/PullRequest/Domain/Aggregate/PullRequest/PullRequest.php
@@ -51,7 +51,6 @@ public function requestChanges(): void
      */
     public function addLabelByApprovalCount(array $committers): void
     {
-        // Todo: use enum instead
         $validApprovals = array_filter(
             $this->approvals,
             static fn (Approval $approval) => in_array($approval->author, $committers, true)

diff --git a/src/PullRequestDashboard/Domain/Aggregate/PullRequestCard/PullRequestCard.php b/src/PullRequestDashboard/Domain/Aggregate/PullRequestCard/PullRequestCard.php
@@ -51,7 +51,6 @@ public function moveColumnByLabel(string $label): void
      */
     public function moveByApprovalCount(array $committers): void
     {
-        // Todo: use enum
         $validApprovals = array_filter(
             $this->pullRequest->approvals,
             static fn (Approval $approval) => in_array($approval->author, $committers, true)

diff --git a/src/PullRequestDashboard/Infrastructure/Adapter/GraphqlGithubPullRequestCardRepository.php b/src/PullRequestDashboard/Infrastructure/Adapter/GraphqlGithubPullRequestCardRepository.php
@@ -11,7 +11,6 @@
 use App\PullRequestDashboard\Domain\Gateway\PullRequestCardRepositoryInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
-// Todo: to test and optimize
 class GraphqlGithubPullRequestCardRepository implements PullRequestCardRepositoryInterface
 {
     public function __construct(private readonly HttpClientInterface $githubClient)

diff --git a/src/Shared/Infrastructure/Factory/CommandFactory/Strategy/RequestChangesStrategy.php b/src/Shared/Infrastructure/Factory/CommandFactory/Strategy/RequestChangesStrategy.php
@@ -7,7 +7,6 @@
 use App\PullRequest\Application\Command\RequestChangesCommand;
 use App\Shared\Infrastructure\Factory\CommandFactory\CommandStrategyInterface;
 
-// Todo: use enum
 class RequestChangesStrategy implements CommandStrategyInterface
 {
     /**

diff --git a/tests/PullRequest/Application/CommandHandler/AddLabelByAapprovalCountCommandHandlerTest.php b/tests/PullRequest/Application/CommandHandler/AddLabelByAapprovalCountCommandHandlerTest.php
@@ -53,7 +53,7 @@ public function testHandle(array $originalLabels, PullRequestId $pullRequestId,
         $pr = $this->prRepository->find(
             new PullRequestId(repositoryOwner: $pullRequestId->repositoryOwner, repositoryName: $pullRequestId->repositoryName, pullRequestNumber: $pullRequestId->pullRequestNumber)
         );
-        // todo : add enum instead
+
         $this->assertEquals($expectedLabels, $pr->getLabels());
     }
 

diff --git a/tests/PullRequest/Application/CommandHandler/RequestChangesCommandHandlerTest.php b/tests/PullRequest/Application/CommandHandler/RequestChangesCommandHandlerTest.php
@@ -45,7 +45,7 @@ public function testHandle(PullRequestId $pullRequestId, array $originalLabels):
         ));
         /** @var PullRequest $pr */
         $pr = $this->prRepository->find($pullRequestId);
-        // todo : add enum instead
+
         $this->assertCount(
             1,
             array_filter(

diff --git a/tests/PullRequest/Infrastructure/Adapter/RestPullRequestRepositoryTest.php b/tests/PullRequest/Infrastructure/Adapter/RestPullRequestRepositoryTest.php
@@ -4,8 +4,6 @@
 
 namespace App\Tests\PullRequest\Infrastructure\Adapter;
 
-use App\PullRequest\Domain\Aggregate\PullRequest\PullRequestId;
-use App\PullRequest\Infrastructure\Adapter\RestPullRequestRepository;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 
 class RestPullRequestRepositoryTest extends KernelTestCase

diff --git a/...plication/CommandHandler/MovePullRequestCardToColumnByApprovalCountCommandHandlerTest.php b/...plication/CommandHandler/MovePullRequestCardToColumnByApprovalCountCommandHandlerTest.php
@@ -107,7 +107,7 @@ public function testHandle(string $originalColumn, PullRequestCardId $pullReques
         ));
         /** @var PullRequestCard $pullRequestCard */
         $pullRequestCard = $this->pullRequestCardRepository->find($pullRequestCardId);
-        // Todo : add enum instead
+
         $this->assertSame($expectedColumnName, $pullRequestCard->getColumnName());
     }
 

diff --git a/...board/Application/CommandHandler/MovePullRequestCardToColumnByLabelCommandHandlerTest.php b/...board/Application/CommandHandler/MovePullRequestCardToColumnByLabelCommandHandlerTest.php
@@ -68,7 +68,7 @@ public function testHandle(string $originalColumn, string $label, string $expect
         ));
         /** @var PullRequestCard $pullRequestCard */
         $pullRequestCard = $this->pullRequestCardRepository->find($pullRequestCardId);
-        // todo : add enum instead
+
         $this->assertSame($expectedColumn, $pullRequestCard->getColumnName());
     }
 

diff --git a/...ullRequestDashboard/Infrastructure/Adapter/GraphqlGithubPullRequestCardRepositoryTest.php b/...ullRequestDashboard/Infrastructure/Adapter/GraphqlGithubPullRequestCardRepositoryTest.php
@@ -4,11 +4,6 @@
 
 namespace App\Tests\PullRequestDashboard\Infrastructure\Adapter;
 
-use App\PullRequestDashboard\Domain\Aggregate\PullRequestCard\Approval;
-use App\PullRequestDashboard\Domain\Aggregate\PullRequestCard\PullRequest;
-use App\PullRequestDashboard\Domain\Aggregate\PullRequestCard\PullRequestCard;
-use App\PullRequestDashboard\Domain\Aggregate\PullRequestCard\PullRequestCardId;
-use App\PullRequestDashboard\Infrastructure\Adapter\GraphqlGithubPullRequestCardRepository;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 
 class GraphqlGithubPullRequestCardRepositoryTest extends KernelTestCase