Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry configuration when calling github api #28

Merged
merged 1 commit into from Oct 12, 2023
Merged

Add retry configuration when calling github api #28

merged 1 commit into from Oct 12, 2023

Conversation

boherm
Copy link
Member

@boherm boherm commented Oct 12, 2023 •
edited

Questions Answers
Description? Add configuration to permit the retry when calling the github api.
Retry 3 times in some http code cases:
- first after 1000 ms,
- then after 2000 ms,
- and finally after 4000 ms.

With 8000 ms limit max of delay.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#34175
Sponsor company PrestaShop SA
How to test? Nothing to really test here 馃槄

@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Oct 12, 2023
@boherm boherm removed the Waiting for QA Status: Waiting for QA feedback label Oct 12, 2023
@boherm boherm merged commit 0eecfdd into PrestaShop:main Oct 12, 2023
7 checks passed
@boherm boherm deleted the #34175-add-retry-when-calling-github-api branch October 12, 2023 14:52
matks
matks reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waaah 馃槃 I did not know Symfony HttpClient had async capabilities but yes it does!

I'm a little afraid of what happens behind the scenes though 馃槢

@boherm boherm mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks left review comments

@nicosomb nicosomb nicosomb approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@tleon tleon tleon approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
No milestone
7 participants
@boherm @nicosomb @matthieu-rolland @matks @tleon @M0rgan01 @ps-jarvis