PR Management documentation #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AureRita
commented
Oct 17, 2023
AureRita
commented
| Questions | Answers |
|---|---|
| Description | Create the documentation to "how to test manually a PR" |
| Fixed ticket | NA |
Robin-Fischer-PS
requested changes
Oct 30, 2023
content/project-organization/quality-council/processes/pr-management.md
Outdated
Show resolved
Hide resolved
content/project-organization/quality-council/processes/pr-management.md
Outdated
Show resolved
Hide resolved
| To do this, go to your terminal and execute the commands below: | ||
|
|
||
|
|
||
| ℹ️ For your information, I recommend that you put it in the *Computer/var/www/html* folder. |
There was a problem hiding this comment.
For Mac it's the same or not? Maybe it would be useful to precise specify which environment is targeted by this documentation.
|
|
||
| We can see that in **violet** we've put the "**Branch "** we're interested in and in **brown** the name of our file, which can be modified as we wish. | ||
|
|
||
| Still with this **Branch**, I advise you to launch the automated Tests. To do this, I suggest you look at the end of this chapter dedicated to it. |
There was a problem hiding this comment.
Suggested change
| Still with this **Branch**, I advise you to launch the automated Tests. To do this, I suggest you look at the end of this chapter dedicated to it. | |
| Still with this **Branch**, we advise you to launch the automated Tests. To do this, we suggest you to look at the end of the chapter dedicated to it. |
|
|
||
| We can see that in **violet** we've put the "**Branch "** we're interested in and in **brown** the name of our file, which can be modified as we wish. | ||
|
|
||
| Still with this **Branch**, I advise you to launch the automated Tests. To do this, I suggest you look at the end of this chapter dedicated to it. |
There was a problem hiding this comment.
I can't find the chapter dedicated to the launch of automated tests, is it me or it's missing?
|  | ||
|
|
||
| - The PR is not valid. In this case, indicate that it doesn't work, put a video showing that it doesn't work and put the link to the automated tests (to prove that it brings issues). | ||
| In your comment, you'll need to select the Comment option before submitting the review. The Request changes option doesn't work properly. |
There was a problem hiding this comment.
Is this part still up to date?
There was a problem hiding this comment.
Don't know, I continue to apply this method because if we don't, we have to accept the PR at the end, another QA can't approve it
content/project-organization/quality-council/processes/pr-management.md
Outdated
Show resolved
Hide resolved
content/project-organization/quality-council/processes/pr-management.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Robin-Fischer-PS <55688534+Robin-Fischer-PS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.