Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alumni role #247

Merged
merged 1 commit into from Jan 16, 2024
Merged

Add alumni role #247

merged 1 commit into from Jan 16, 2024

Conversation

matks
Copy link
Contributor

@matks matks commented Jan 15, 2024

Questions Answers
Description See #92
Fixed ticket Fixes #92

@matks
Copy link
Contributor Author

matks commented Jan 15, 2024

Thanks @Hlavtox 😉 I'll wait a little before merging to gather a little more feedback

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice concept 👍

@matks
Copy link
Contributor Author

matks commented Jan 16, 2024

I got not negative feedbacks from anybody I shared it with, I have been talking about it with people for a week now, and it has 3 approvals: I think we can say it's a YES by lazy consensus

@matks matks merged commit 27b8aec into PrestaShop:master Jan 16, 2024
1 check passed
@matks matks deleted the add-alumni branch January 16, 2024 12:50
@matks matks mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Introducing alumni
5 participants