Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create site #60

Merged
merged 9 commits into from Jun 18, 2021
Merged

Create site #60

merged 9 commits into from Jun 18, 2021

Conversation

eternoendless
Copy link
Member

@eternoendless eternoendless commented Jun 17, 2021 •
edited

Questions Answers
Description Added a new site for the project
  • Blog sends you to Build
  • Contribute to the appropriate section on Devdocs
  • Resources contains a link to the code of conduct and the user groups part

TO DO:

  • Slack section
  • Find links for the page footer
  • Complete the About section (hidden for now)
  • Move the theme to the org (in my fork right now)

For later:

  • Move the maintainer's guide from the devdocs

Screenshot:

Screencap

Progi1984
Progi1984 reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

.gitmodules Outdated Show resolved Hide resolved
content/about.md Outdated Show resolved Hide resolved
Pablo Borowicz and others added 3 commits June 17, 2021 14:48
Replace open source artwork
7cc397f
Update theme URL
30984e8
@Progi1984
Add dot
d33b30a 
Co-authored-by: Progi1984 <progi1984@gmail.com>
matks
matks approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is ✅ for me. I added a suggestion.

config/_default/params.yml
projectUrls:
gitHub: "https://github.com/PrestaShop/PrestaShop/"
reportBug: "https://github.com/PrestaShop/PrestaShop/issues"
slack: "https://github.com/PrestaShop/open-source/blob/master/slack/readme.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file /slack/readme.md will now be available as one webpage on prestashop-project.org ? One resources page?

@ttoine
Copy link
Contributor

ttoine commented Jun 18, 2021

How can I add the missing sections?
Do we merge that first and then I'll do pull requests?

NeOMakinG
NeOMakinG approved these changes Jun 18, 2021
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Progi1984 Progi1984 merged commit 990c225 into PrestaShop:master Jun 18, 2021
@ttoine
Copy link
Contributor

ttoine commented Jun 18, 2021

so, now that it is merged, is it online somewhere already ?

@Progi1984
Copy link
Contributor

Progi1984 commented Jun 18, 2021 •
edited

Nope. Why ?

  • The DNS rule has not been done for the new domain.
  • @eternoendless has detected an error in Github Actions 😉

@ttoine
Copy link
Contributor

ttoine commented Jun 18, 2021

because I don't know, so I ask ;-)
can't wait to see it live and be able to add content to it, btw.

@Progi1984
Copy link
Contributor

The why is for the explanation.

@eternoendless eternoendless deleted the hugo-site branch June 21, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eternoendless @ttoine @Progi1984 @PierreRambaud @matks @NeOMakinG