Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run): custom script runner #17

Merged
merged 2 commits into from Oct 31, 2023
Merged

fix(run): custom script runner #17

merged 2 commits into from Oct 31, 2023

Conversation

jokesterfr
Copy link
Collaborator

@jokesterfr jokesterfr commented Oct 31, 2023 •
edited

  • fixes script run order (now alphabetically)
  • indent with 2 spaces every subscript
  • pass env variables through sudo to pass docker-compose variables
  • add an example

@jokesterfr jokesterfr self-assigned this Oct 31, 2023
@jokesterfr jokesterfr merged commit 053cdaa into main Oct 31, 2023
8 checks passed
@jokesterfr jokesterfr deleted the fix/script-run branch October 31, 2023 15:34
Venatum
Venatum approved these changes Oct 31, 2023
View reviewed changes
examples/with-custom-scripts/README.md
The expected output of this example is:

```
❯ docker-compose up prestashop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
❯ docker-compose up prestashop
❯ docker compose up prestashop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Venatum Venatum Venatum approved these changes

Assignees

@jokesterfr jokesterfr

Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jokesterfr @Venatum