Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): PS_VERSION as a tag if the recommended PHP version is used #24

Merged
merged 1 commit into from Nov 24, 2023

Conversation

jokesterfr
Copy link
Collaborator

@jokesterfr jokesterfr commented Nov 24, 2023

Questions Answers
Description? Getting tags with the PrestaShop version is more handy, and will stand for the default OS_FLAVOUR (alpine linux) and for the recommended PHP version.
Type? packaging
BC breaks? no
Deprecations? no
How to test? ./build.sh && docker images

@jokesterfr jokesterfr changed the title Add a default tag if the recommended version is given chore(build): add a default tag if the recommended version is given Nov 24, 2023
@jokesterfr jokesterfr self-assigned this Nov 24, 2023
@jokesterfr jokesterfr changed the title chore(build): add a default tag if the recommended version is given chore(build): PS_VERSION as a tag if the recommended version is used Nov 24, 2023
@jokesterfr jokesterfr changed the title chore(build): PS_VERSION as a tag if the recommended version is used chore(build): PS_VERSION as a tag if the recommended PHP version is used Nov 24, 2023
@jokesterfr jokesterfr merged commit 52fdf82 into main Nov 24, 2023
8 checks passed
@jokesterfr jokesterfr deleted the fix/build-add-extra-tags branch November 24, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant