Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from 8M to 20M to support more modules #67

Merged
merged 2 commits into from Jan 29, 2024
Merged

Move from 8M to 20M to support more modules #67

merged 2 commits into from Jan 29, 2024

Conversation

jokesterfr
Copy link
Collaborator

@jokesterfr jokesterfr commented Jan 29, 2024 •
edited

Questions Answers
Description? Usually modules can be big. 20M should be more than enough.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #68 #66
Sponsor company PrestaShop (@Thymotep)
How to test? Upload a <20M module, and check server info in PrestaShop Back Office.

matks
matks reviewed Jan 29, 2024
View reviewed changes
Copy link

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the PR description table? 😛

@jokesterfr jokesterfr self-assigned this Jan 29, 2024
@jokesterfr jokesterfr mentioned this pull request Jan 29, 2024
Closed
@jokesterfr jokesterfr merged commit fa9b364 into main Jan 29, 2024
10 checks passed
@jokesterfr jokesterfr deleted the fix/php-ini-max-size branch January 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks left review comments

Assignees

@jokesterfr jokesterfr

Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8M is not enough for most of the volumes
2 participants
@jokesterfr @matks