Custom prestashop release #96
Conversation
Alexandre-Lematre
commented
Apr 18, 2024
•
Alexandre-Lematre
commented
| Questions | Answers |
|---|---|
| Description? | Adds the ability to build a release based on a custom prestashop zip containing a list of modules |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| Sponsor company | PrestaShop |
| How to test? | Try to build a release with the PrestaShop Classic Edition zip |
| declare PLATFORM; # -- alias for $TARGET_PLATFORM | ||
| declare TARGET_IMAGE; # -- docker image name, defaults to "prestashop/prestashop-flashlight" | ||
| declare PUSH; # -- set it to "true" if you want to push the resulting image | ||
| declare ZIP_SOURCE; # -- the zip to unpack in flashlight |
There was a problem hiding this comment.
We do actually have an open PR on this one! Can we merge ideas?
There was a problem hiding this comment.
Sure. Can you tell me what PR is this ? I can't find it
There was a problem hiding this comment.
Was thinking about that one : #82
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
2 times, most recently
from
46f0830
to
9e081f4
Compare
| declare TARGET_IMAGE; # -- docker image name, defaults to "prestashop/prestashop-flashlight" | ||
| declare PUSH; # -- set it to "true" if you want to push the resulting image | ||
| declare ZIP_SOURCE; # -- the zip to unpack in flashlight | ||
| declare PRE_INSTALLED_MODULES; # -- install modules during zip installation |
There was a problem hiding this comment.
I don't think this should come along with the build time. It's rather a variable to be declared on top of assets/run.sh
| @@ -47,6 +48,8 @@ ARG PHP_VERSION | |||
| ARG GIT_SHA | |||
| ARG PS_FOLDER=/var/www/html | |||
| ARG ZIP_SOURCE | |||
| ARG PRE_INSTALLED_MODULES | |||
| ENV PRE_INSTALLED_MODULES=$PRE_INSTALLED_MODULES | |||
There was a problem hiding this comment.
is it really something you wanna provide at build time?
There was a problem hiding this comment.
These modules have to be installed during PrestaShop installation, so, at build time ; the aim being to provide a custom release, shiped with a bunch of modules (like classic and hosted edition)
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
9e081f4
to
feb5333
Compare
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
feb5333
to
62b6e9a
Compare
