Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs customer settings #335

Merged
merged 26 commits into from Oct 25, 2022
Merged

Specs customer settings #335

merged 26 commits into from Oct 25, 2022

Conversation

Saimis777
Copy link
Contributor

Questions Answers
Description? Please be specific when describing the PR. What did you add, why did you submit it?
Fixed ticket? Fixes #{issue number here} if there is a related issue

@Saimis777 Saimis777 added the WIP Work in progress label Apr 20, 2022
@Saimis777 Saimis777 added Review required Specifications to be reviewed and removed WIP Work in progress labels Apr 22, 2022

# Groups

## Columns

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add filters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify what needs to be fixed here? I've described the filtering (search) and the sorting in the columns @fabienvallon

After clicking on "Delete selected", a modal with the title "Delete selection" is opened asking to confirm or cancel the action: "Are you sure you want to delete the selected item(s)?" (See issue [#14462](https://github.com/PrestaShop/PrestaShop/issues/14462)). The action can be canceled by clicking on the cross or on the cancel button.
After clicking on "Delete" button, the selected groups are deleted, a successful message is displayed "The selection has been successfully deleted.".

# Default groups options

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describe business rules (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabienvallon where can I find the business rules?

@fabienvallon fabienvallon added Waiting for author Waiting for author feedback and removed Review required Specifications to be reviewed labels Apr 29, 2022
@MatShir MatShir merged commit 96d51f8 into master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for author Waiting for author feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants